Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved classification of subdivision/unit #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

missinglink
Copy link
Member

branched from stopword-classification, requires #179 be merged first.

This PR is an attempt at solving #178 with minimal changes.

However, it seems to solve a longstanding issue which was more widespread, namely having a space between HouseNumber and UnitNumber:

node bin/cli.js 10 A Main Street

# before
(0.98) ➜ [ { housenumber: '10' }, { street: 'A Main Street' } ]

# after
(0.86) ➜ [ { housenumber: '10 A' }, { street: 'Main Street' } ]

I'm going to have a think about this before merging, it feels 'too easy', I'm sure it comes with some pitfalls.

Closes #178

@missinglink missinglink requested a review from Joxit September 9, 2024 10:02
@@ -217,23 +217,23 @@ const testcase = (test, common) => {
]], false)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are required as the parser previously returned a single result for these queries, it now returns two, but the expected result is still the highest scoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

France: bis/ter housenumber suffixes
1 participant