Node.js 18 Docker image and CI updates #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't really save us much effort and breaks CI on forks. Connects pelias/pelias#951
This also rewrites our CI config so that all Node.js versions are on one line for ease of future grepping pelias/pelias#950
A lot of our repositories have diverged from our intended template, so this copies a templated version over whatever was here before Connects pelias/pelias#951
BREAKING CHANGE: The Docker baseimage has been updated to use Node.js 18.20.5, so this repository's Docker image will also use it. pelias/pelias#950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a bunch of commits made by a script that standardizes as much as possible our CI config across all repositories.
Along the way it also ensures we test all Node.js versions that are an LTS release, not EOL, and currently work with this repository. Any Github Actions that were out of date or used old Node.js versions (checkout and setup-node
v2) are also updated. The openstreetmap importer and all others will need updatedwhosonfirst/wof-admin-lookupdeps with a new version ofbetter-sqlite3before we can add Node.js 22 support.Also, the CI OS version is now hardcoded to ubuntu-22.04. We fooled around with an organization wide CI variable to configure that, but it broke CI in forks and doesn't really help us much, so it's now undone.
If there are any other differences in Github Actions Workflow files, they are also now removed by using a standard template.
Finally, because this repository has a Dockerfile and we just updated the Docker baseimage to support Node.js 18, there is an empty commit to trigger a new major version release.
Connects pelias/pelias#950
Connects pelias/pelias#951