Skip to content

Commit

Permalink
feat(tags): Add two new OSM venue tags; add operator/brand to addendum
Browse files Browse the repository at this point in the history
Add two new OSM venue tags; add operator/brand to addendum (#528)

* Add Brand and Operator to addendum tags

* Fix end-to-end tests

* Add brand+name and healthcare+name to venue tag list

* Add test for new venue_tags

* Update e2e test data

Co-authored-by: Jen Weiss <[email protected]>
  • Loading branch information
thismakessand and Jen Weiss authored May 7, 2020
1 parent 5fee73d commit 967c5d5
Show file tree
Hide file tree
Showing 5 changed files with 751 additions and 177 deletions.
4 changes: 3 additions & 1 deletion config/features.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ var venue_tags = [
'aeroway~spaceport+name',
'aeroway~landing_strip+name',
'aeroway~airfield+name',
'aeroway~airport+name'
'aeroway~airport+name',
'brand+name',
'healthcare+name'
];

module.exports = {tags,venue_tags};
2 changes: 2 additions & 0 deletions stream/addendum_mapper.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ const whitelist = [
'icao', // ICAO airport codes
'wikidata', // Wikidata concordance
'wikipedia', // Wikipedia concordance
'operator', // Operator name
'brand', // Brand name
// 'website', // Website URL
// 'phone', // Telephone number
// 'opening_hours', // Opening hours
Expand Down
2 changes: 2 additions & 0 deletions test/config/features.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ module.exports.tests.whitelist = function(test, common) {
t.false( features.venue_tags.indexOf('aeroway~landing_strip+name') <0 );
t.false( features.venue_tags.indexOf('aeroway~airfield+name') <0 );
t.false( features.venue_tags.indexOf('aeroway~airport+name') <0 );
t.false( features.venue_tags.indexOf('brand+name') <0 );
t.false( features.venue_tags.indexOf('healthcare+name') <0 );
t.end();
});
};
Expand Down
Loading

0 comments on commit 967c5d5

Please sign in to comment.