Added Tooltip to BottomNavyBar.items #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonio-pedro99
approved these changes
Sep 16, 2023
There was a problem hiding this comment.
Hello @shahabhm, thanks for this PR and for your patient!
The PR looks good to me
|
@shahabhm would you mind adding tests so that we make sure this feat does not break the Widget? |
|
@antonio-pedro99 Hi. Thanks for reviewing the PR. But It has been quite a few years since I've coded anything for mobiles and I don't remember anything about it :). Unfortunately, I cannot help with this issue anymore. |
antonio-pedro99
force-pushed
the
issue_50_1
branch
from
78a816b to
ab1ab13
Compare
Signed-off-by: António Pedro <[email protected]>
antonio-pedro99
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
@shahabhm thanks for the PR.
Added some tests and fixed the merge conflicts!
Merged!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. after converting items to widgets we can't easily set the background of the items and it will be obtained from theme and indexing needs to be managed manually. also apps using this widget might need to conform to the changes. therefore I have edited the code in a way the structure doesn't change but it's possible to easily add tooltips; you just need to specify the text while creating a BottomNavyBarItem.
here's how it will look like:
This fixes #50