Minimized the space between the icon and the title #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/bottom_navy_bar.dart
Outdated
| @@ -162,23 +162,22 @@ class _ItemWidget extends StatelessWidget { | |||
| container: true, | |||
| selected: isSelected, | |||
| child: AnimatedContainer( | |||
| width: isSelected ? 130 : 50, | |||
| width: isSelected ? 130 : 50, // Limit the width here | |||
There was a problem hiding this comment.
What is the reason to add this comment?
There was a problem hiding this comment.
hey @Sanskar2807 thanks a lot for your PR.
I have left some comments.
lib/bottom_navy_bar.dart
Outdated
| borderRadius: BorderRadius.circular(itemCornerRadius), | ||
| ), | ||
| child: SingleChildScrollView( | ||
| scrollDirection: Axis.horizontal, | ||
| physics: NeverScrollableScrollPhysics(), | ||
| child: Container( | ||
| width: isSelected ? 130 : 50, | ||
| width: isSelected ? 130 : 50, // Limit the width here |
There was a problem hiding this comment.
see my previous comment
example/lib/main.dart
Outdated
| @@ -71,7 +71,7 @@ class _MyHomePageState extends State<MyHomePage> { | |||
| BottomNavyBarItem( | |||
| icon: Icon(Icons.message), | |||
| title: Text( | |||
| 'Messages test for mes teset test test ', | |||
There was a problem hiding this comment.
That example is on purpose!
|
All checks have failed, do you mind take a look? |
'Messages test for mes teset test test '' Miniimized the gap
There was a problem hiding this comment.
Hi again @Sanskar2807.
Thanks for the hard work you are putting on this.
I would stay with the current behavior, IMHO.
Use usually expect menu items to have only one word, or at least two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #111
Demo screenshot
