Add support for the input tag
#4
Conversation
| def input(record_name, method, options = {}) | ||
| raise_broken_code_error | ||
| InstanceTag.new(record_name, method, self).to_tag(options) | ||
| # # => <input id="post_title" name="post[title]" size="30" maxlength="30" type="text" value="Hello World" /> |
There was a problem hiding this comment.
I find more value in adding the maxlength attribute as well, in addition to the size.
| # # => <input id="post_title" name="post[title]" size="30" type="text" value="Hello World" /> | ||
| def input(record_name, method, options = {}) | ||
| raise_broken_code_error | ||
| InstanceTag.new(record_name, method, self).to_tag(options) |
There was a problem hiding this comment.
This was inspired by the deprecated class InstanceTag and relied on methods such as to_input_field_tag that are no longer available. Instead I'm using Tags::TextField or similars.
|
|
||
| def options_with_default | ||
| @options.tap do |options| | ||
| options["maxlength"] = DEFAULT_MAXLENGTH unless @options.key?("maxlength") |
There was a problem hiding this comment.
the render methods sets the size attribute based on the maxlength option https://github.com/rails/rails/blob/main/actionview/lib/action_view/helpers/tags/text_field.rb#L11-L18
| when :time | ||
| Tags::TimeField.new(*generic_args).render | ||
| when :boolean | ||
| Tags::CheckBox.new(@object_name, @method, @context, "1", "0", @options).render |
There was a problem hiding this comment.
In my opinion, setting the maxlength attribute for a checkbox input doesn't make much sense
| when :time | ||
| Tags::TimeField.new(*generic_args).render | ||
| when :boolean | ||
| Tags::CheckBox.new(@object_name, @method, @context, "1", "0", @options).render |
There was a problem hiding this comment.
It makes sense for this tag to be a checkbox input instead of a select, as previously https://api.rubyonrails.org/v3.1.3/classes/ActionView/Helpers/InstanceTag.html#method-i-to_boolean_select_tag
Add support for the
inputtag for usage asinput("post", "title").