-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(3DS): Implement show method and return response with enriched nonce #2452
Open
siddy2181
wants to merge
66
commits into
main
Choose a base branch
from
fastlane-3ds-e2e
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchoun
changed the title
[test-only]Fastlane 3ds e2e
feature(3DS): Implement show method and return response with enriched nonce
Dec 6, 2024
mchoun
reviewed
Dec 10, 2024
mchoun
reviewed
Dec 10, 2024
mchoun
reviewed
Dec 10, 2024
mchoun
reviewed
Dec 10, 2024
mchoun
reviewed
Dec 10, 2024
mchoun
reviewed
Dec 10, 2024
wsbrunson
approved these changes
Dec 17, 2024
imbrian
reviewed
Dec 17, 2024
}); | ||
}); | ||
|
||
describe("three domain descure component - show method", () => { | ||
test.todo("should return a zoid component", () => { | ||
describe.todo("three domain descure component - show method", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still todo
. is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow i didn't know you could do that
tests, make show async
siddy2181
force-pushed
the
fastlane-3ds-e2e
branch
from
December 18, 2024 06:06
e62dde1
to
45c51c5
Compare
fix types fix types typecheck
siddy2181
force-pushed
the
fastlane-3ds-e2e
branch
from
December 18, 2024 07:16
4fc4a91
to
97d1ca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ThreeDomainSecureClient component provides a method to the merchant to display the 3DS challenge to the buyer if the response from the
isEligible
method is true. After the buyer has completed the 3DS challenge, theliabilityShift
,authenticationState
, and anonce
with enriched 3DS data will be returned to the merchant.Code Sample:
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
This PR covers the following tickets
DTPPCPSDK-2662
DTPPCPSDK-2665
DTPPCPSDK-2805
DTPPCPSDK-2855
❤️ Thank you!