Fix Percy Screenshot CI Failure #2255
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2255 +/- ##
=======================================
Coverage 51.22% 51.22%
=======================================
Files 104 104
Lines 2007 2007
Branches 587 587
=======================================
Hits 1028 1028
Misses 879 879
Partials 100 100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -30,7 +30,7 @@ | |||
| "start": "npm run webpack -- --progress --watch", | |||
| "test": "npm run format:check && npm run test:unit && npm run jest-ssr && npm run karma && npm run jest-screenshot", | |||
| "test:unit": "vitest run", | |||
| "percy-screenshot": "babel-node ./test/percy/server/createButtonConfigs.js && percy exec -- playwright test --config=./test/percy/playwright.config.js --reporter=dot --pass-with-no-tests", | |||
| "percy-screenshot": "npx playwright install && babel-node ./test/percy/server/createButtonConfigs.js && percy exec -- playwright test --config=./test/percy/playwright.config.js --reporter=dot --pass-with-no-tests", | |||
There was a problem hiding this comment.
do we still need this if we updated percy and playwright in the package.json?
There was a problem hiding this comment.
yes! I only know this because the second commit in this PR upgraded the dependencies and still failed: https://github.com/paypal/paypal-checkout-components/actions/runs/6397759802/job/17366408426 but the third commit added this line and passed 🥳
Another option would be to back out the dependency upgrades and only keep npx playwright install.
Description
This PR fixes two issues with
npm run percy-screenshot:Error: browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium-1080/chrome-linux/chromelink[percy] Heads up! The current version of @percy/cli is more than 10 releases behind! 1.18.0 -> 1.27.2linkWhy are we making these changes?
While working on an unrelated PR, I noticed the percy screenshot was failing. I pushed up an empty commit to this branch to verify the failure was on the
mainbranch and not related to my changes. The error message told me to runnpx playwright install<- I tried that, and it worked! I also tried finding a related change in either Percy or Playwright that would explain why this test started failing but was unable to locate mention of this error after 2022 🤔Screenshots
❤️ Thank you!