Merge pull request #7 from pavel-zhur/feature/frontend-appinsights #1
pavel-zhurAnnotations
1 error and 22 warnings
|
build
The parameter "automatic_release_tag" was not set and the current tag "fv1.0.5" does not appear to conform to semantic versioning.
|
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: marvinpinto/action-automatic-releases@latest. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: marvinpinto/action-automatic-releases@latest. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Components/CollectionComponentBase.cs#L40
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Components/VisitedNavLink.cs#L123
Possible null reference argument for parameter 'prefix' in 'bool VisitedNavLink.IsStrictlyPrefixWithSeparator(string value, string prefix)'.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Models/Fingerings/FingeringsModelIndex.cs#L5
Non-nullable property 'Model' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Models/Fingerings/FingeringsModelIndex.cs#L7
Non-nullable property 'TypesByChordText' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Shared/SearchResultsLocal.razor#L33
Dereference of a possibly null reference.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Shared/SearchResultsLocal.razor#L33
Possible null reference argument for parameter 'value' in 'SongsMode Enum.Parse<SongsMode>(string value)'.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Shared/SearchResultsLocal.razor#L45
Possible null reference argument for parameter 's' in 'long long.Parse(string s)'.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Shared/SearchResultsLocal.razor#L56
Dereference of a possibly null reference.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Shared/SearchResultsLocal.razor#L56
Possible null reference argument for parameter 's' in 'int int.Parse(string s)'.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Shared/SearchResultsLocal.razor#L59
Dereference of a possibly null reference.
|
|
build:
OneShelf.Common/OneShelf.Common.Songs/FullTextSearch/FullTextSearchLogic.cs#L116
Possible null reference argument for parameter 'text' in 'string FullTextSearchLogic.ToSearchSyntax(string text)'.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Api.Model/V3/Api/GetVisitedSearchesRequest.cs#L7
Non-nullable property 'Identity' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Api.Model/V3/Api/GetVisitedChordsRequest.cs#L7
Non-nullable property 'Identity' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Api.Model/V3/Api/GetPdfsResponse.cs#L5
Non-nullable property 'Pdfs' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Api.Model/V3/Api/GetPdfsResponse.cs#L15
Non-nullable property 'PreviewLink' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
HarmonyDB.Index/HarmonyDB.Index.Analysis/Services/ProgressionsBuilder.cs#L273
Dereference of a possibly null reference.
|
|
build:
HarmonyDB.Index/HarmonyDB.Index.Api.Model/VPublic/GetPublicResponse.cs#L7
Non-nullable property 'Artists' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
HarmonyDB.Index/HarmonyDB.Index.Api.Model/VInternal/TryImportResponse.cs#L13
Non-nullable property 'Source' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Components/CollectionComponentBase.cs#L40
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
OneShelf.Frontend/OneShelf.Frontend.Web/Components/VisitedNavLink.cs#L123
Possible null reference argument for parameter 'prefix' in 'bool VisitedNavLink.IsStrictlyPrefixWithSeparator(string value, string prefix)'.
|