Upgrade jax and fix deprecation warnings #915
Merged
+67
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,7 @@ | |||
| import equinox.internal as eqxi | |||
| import jax | |||
| import jax.core | |||
There was a problem hiding this comment.
Thank you for the fix!
By the way, do we need to keep all of the import jax.core around? I'm guessing most of these can be removed.
There was a problem hiding this comment.
Seems you failed to push after removing the unused imports?
There was a problem hiding this comment.
@garymm No, a fair amount of files still need jax.core, hence why it's not removed everywhere.
DrJessop
force-pushed
the
agrebenisan/fix-jax-deprecation-warnings
branch
from
dba54ed to
3f32594
Compare
|
Alright, LGTM! Thank you for the upgrades :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jax v0.4.38 deprecated many APIs in jax.core, and can be replaced instead by jax.extend.core.
Jax v0.4.38 also required me to upgrade python.
Fixes: #913