Spec: export obtain the Private Aggregation coordinator algorithm #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version that takes a USVString is shared between Protected Audience and Shared Storage, so we can export it. Updates links so that the monkey patched version has a modified linking text as that will be removed from this spec soon.
qingxinwu
reviewed
Oct 17, 2024
spec.bs
Outdated
| @@ -2119,37 +2138,18 @@ They return an [=interest group=] or null: | |||
| </div> | |||
|
|
|||
| <div algorithm> | |||
| To <dfn>obtain the Private Aggregation coordinator</dfn> given a | |||
| To <dfn lt="obtain the Private Aggregation coordinator from a PA config">obtain | |||
| the Private Aggregation coordinator</dfn> given a | |||
There was a problem hiding this comment.
nit: is there a reason to keep this the same name as the other? Is it slightly easier to just call it "... from a PA config"
There was a problem hiding this comment.
I was treating them like "overloaded" functions, but I don't feel strongly. That being said, I don't love the "PA config" if it's the proper name -- maybe we could call it "obtain the coordinator from a Private Aggregation config"?
There was a problem hiding this comment.
Went with this!
qingxinwu
approved these changes
Oct 18, 2024
qingxinwu
approved these changes
Oct 18, 2024
|
Thanks! |
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2024
SHA: d98b3fc Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to morlovich/private-aggregation-api
that referenced
this pull request
Oct 21, 2024
…tcg-individual-drafts#163) SHA: d98b3fc Reason: push, by morlovich Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version that takes a USVString is shared between Protected Audience and Shared Storage, so we can export it. Updates links so that the monkey patched version has a modified linking text as that will be removed from this spec soon.
Preview | Diff