Spec: Define per-calling-API limit on contributions per report #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexmturner PTAL :) (Yay, CI gave me a green checkmark because I rebased on #149.) |
dmcardle
changed the title
alexmturner
reviewed
Aug 2, 2024
dmcardle
force-pushed
the
dmcardle-protected-audience-100-contribs-spec
branch
2 times, most recently
from
ee9f46d to
0eba66b
Compare
alexmturner
pushed a commit
that referenced
this pull request
Aug 23, 2024
Modifies the explainer to mention that these limits can be different per-API and to list the planned implementaiton plan (i.e. increasing Protected Audience's limit to 100). For more detail, see #81 (comment). Related spec change: #150
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 27, 2024
This CL implements the logic for limiting Protected Audience callers to 100 contributions per report. Shared Storage callers are not affected. The new behavior is gated behind a feature flag that is disabled by default. * Explainer change: patcg-individual-drafts/private-aggregation-api#138 * Spec change: patcg-individual-drafts/private-aggregation-api#150 Bug: 360160864 Change-Id: I14cd4087986a8ecb70e60701d56fac6d25135a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5743397 Commit-Queue: Dan McArdle <[email protected]> Reviewed-by: Alex Turner <[email protected]> Cr-Commit-Position: refs/heads/main@{#1347486}
alexmturner
reviewed
Sep 3, 2024
alexmturner
approved these changes
Sep 3, 2024
dmcardle
force-pushed
the
dmcardle-protected-audience-100-contribs-spec
branch
from
0eba66b to
5c54351
Compare
github-actions bot
added a commit
that referenced
this pull request
Sep 3, 2024
SHA: 419c30e Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corresponds to
Note that this PR depends on #149. (GitHub doesn't understand dependent PRs, so this appears to include its parent's changes.)Preview | Diff