Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Models] Enable nullable (1 of x) #581

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Conversation

iamcarbon
Copy link
Contributor

This is the first of a few PR's to enable nullable on the models project and close #466

This PR:

  • Matches the requiredness of various properties with the specifications. Some properties were annotated with required instead, to limit churn in our tests
  • Makes a few more classes immutable

The next PR will turn enable nullable at the project level

Posting for early review / feedback.

@iamcarbon
Copy link
Contributor Author

@joegoldman2 @abergs Review for review / feedback. We should get these final nullability changes in before the 4.0 release.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.03%. Comparing base (f8471ac) to head (dd2d208).

Files with missing lines Patch % Lines
...bjects/AuthenticationExtensionsLargeBlobOutputs.cs 0.00% 3 Missing ⚠️
...Fido2.Models/Objects/CredentialPropertiesOutput.cs 0.00% 2 Missing ⚠️
Src/Fido2.Models/Objects/Version.cs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files         101      101           
  Lines        2600     2600           
  Branches      432      432           
=======================================
  Hits         1977     1977           
  Misses        513      513           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@iamcarbon
Copy link
Contributor Author

@abergs Quick ping on this. There's one more PR after this to flipping on enable on the project and updating the directives. That should be the last of the churn for Models in the 4.0 cycle.

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iamcarbon, looks good!

@abergs abergs merged commit b7f1735 into passwordless-lib:master Dec 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable nullable for Fido2.Models
3 participants