Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Long column names are cut off in the "Manage Columns" menu #2353

Open
wants to merge 5 commits into
base: alpha
Choose a base branch
from
Open

fix: Long column names are cut off in the "Manage Columns" menu #2353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8edd079
Merge pull request #1 from parse-community/alpha
Magdaraa Oct 4, 2022
4781f41
fix: "Manage Columns" tab cuts off long column names
Magdaraa Dec 26, 2022
119561e
Merge branch 'alpha' into fix-manage-columns
mtrezza Dec 27, 2022
a75f58b
Merge branch 'alpha' into fix-manage-columns
mtrezza Jan 27, 2023
eaabb08
Merge branch 'alpha' into fix-manage-columns
mtrezza Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/ColumnsConfiguration/ColumnConfigurationItem.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@

.visibilityIcon {
cursor: pointer;
width: 30px;
}

.columnConfigItemName {
text-overflow: ellipsis;
overflow: hidden;
line-height: 24px;
margin-left: 15px;
margin-right: 15px;
}

.columnIcon {
Expand Down
9 changes: 8 additions & 1 deletion src/components/ColumnsConfiguration/ColumnsConfiguration.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@
this.entryRef = React.createRef();
}

componentDidMount() {
const rect = this.entryRef.current?.getBoundingClientRect();
this.maxWidth = rect.x + rect.width - 20 + 'px';
}

componentWillReceiveProps(props) {
if (props.schema !== this.props.schema) {
this.setState({
Expand Down Expand Up @@ -107,7 +112,9 @@
>
<div className={styles.popover} id={POPOVER_CONTENT_ID}>
{title}
<div className={styles.body}>
<div className={styles.body} style={{
maxWidth: this.maxWidth,

Check failure on line 116 in src/components/ColumnsConfiguration/ColumnsConfiguration.react.js

View workflow job for this annotation

GitHub Actions / Lint 

Expected indentation of 14 spaces but found 16
}}>

Check failure on line 117 in src/components/ColumnsConfiguration/ColumnsConfiguration.react.js

View workflow job for this annotation

GitHub Actions / Lint 

Expected indentation of 12 spaces but found 14
<div className={styles.columnConfigContainer}>
<DndProvider backend={HTML5Backend}>
{order.map(({ name, visible, ...rest }, index) => {
Expand Down
3 changes: 2 additions & 1 deletion src/components/ColumnsConfiguration/ColumnsConfiguration.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@
right: 0;
border-radius: 5px 0 5px 5px;
background: #797691;
width: 320px;
max-width: 100vw;
min-width: 320px;
font-size: 14px;

.columnConfigContainer {
Expand Down
Loading