feat: check duplicate calls to base constructor #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Dec 16, 2024
| )) | ||
| .span(main_contract.name.span) | ||
| .emit(); | ||
| self.dcx().note("first call here").span(bc_error.first_call_span).emit(); |
There was a problem hiding this comment.
these should be notes on the error, this creates a separate diagnostic
| } | ||
| } | ||
|
|
||
| for bc_error in bc_errors { |
There was a problem hiding this comment.
you can make this a closure that is called instead of pushing
| @@ -196,6 +196,84 @@ impl super::LoweringContext<'_, '_, '_> { | |||
| } | |||
| } | |||
|
|
|||
| #[instrument(level = "debug", skip_all)] | |||
| pub(super) fn check_base_ctor_args(&self) { | |||
| for main_contract in self.hir.contracts() { | |||
There was a problem hiding this comment.
why is this using the AST instead of being a HIR check like the other ones you did? this shouldnt happen during lowering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ethereum/solidity/blob/df01dcc7b759f53ba45811979d3286562eab7846/libsolidity/analysis/ContractLevelChecker.h#L73C2-L78C4