-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): Add address_
namespace and bindings
#4146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supportive, since this doesn't add any overhead,
but like to see some serde examples how the request response objects should look like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would want this to be documented fully in the book (e.g. in book/jsonrpc
) in the same PR since it isn't a standard namespace
1f7fb3b
to
fd7dc68
Compare
Docs added and examples included that mirror the spec/spectests |
Just to make this explicit would like to be sensitive with merging this upstream and maintaining the code..so I am happy we're iterating on it and would like to ideally figure out how to run it as a separate binary as well? |
Thanks, appreciate that. I consider this family (4054) an exploration of "what could this feature look like, and how could it be implemented?", with the outcome being discovery of whether it is a good feature and what a good implementation could look like. Happy to explore the design space including specific ideas anyone has. Could you expand the concept of a separate binary more? On first take it sounds like you are describing the following: Currently, the Execution stage has inspectors that can gather data. The result of the inspector could be stored directly in to a table alongside other tables in reth, alternatively it could call a separate binary and pass the inspector data over. The separate binary listens for and accepts the data, processes and stores in some representation that reth is unaware of. Then to serve the method reth and the separate binary again call each other (depending on where the call is set up to be served from) and the data aggregated for the response. |
Closing this as stale, we'll re-incorporate these ideas as we venture into custom stages with Reth CLI Extensions and the Declarative Node Builder API that @mattsse is spearheading. |
Description
Progress toward:
Changes
address_
namespace addition including:- add
AddressApi
trait in rpc-api- add to RPC builder
- add placeholder implementation for
address_getAppearances