feat: impl compression traits for op primitives #13550
Merged
+55
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
joshieDo,
rakita,
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
CodSpeed Performance ReportMerging #13550 will not alter performanceComparing Summary
|
klkvr
force-pushed
the
klkvr/impl-compress-for-op
branch
from
c180dfc to
1b6a552
Compare
klkvr
commented
Dec 24, 2024
| @@ -50,7 +50,7 @@ arbitrary.workspace = true | |||
| proptest.workspace = true | |||
|
|
|||
| [features] | |||
| default = ["std"] | |||
| default = ["std", "serde"] | |||
There was a problem hiding this comment.
this is needed because reth-primitives enables reth-primitives-traits/serde by default, thus reth-optimism-traits does not compile unless serde is enabled :/
once we migrate to alloy block types we should be able to get rid of reth_primitives dependency and this hack
mattsse
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
impl_compression_for_compactinvocation for op types.Additionally changes op-primitives crate to only bound the
FillTxEnvimpl behindoptimismfeature, that way we don't have to enable revm optimism feature to use the crate