Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug client etherscan #13542

Merged
merged 4 commits into from
Dec 25, 2024
Merged

Conversation

greged93
Copy link
Contributor

Fixes the tag for the debug client, as the Display implementation for BlockNumberOrTag will add number at the beginning of the string for the Number variant.

Signed-off-by: Gregory Edison <[email protected]>
@greged93 greged93 changed the title fix: tag debug client fix: debug client Dec 24, 2024
@greged93 greged93 changed the title fix: debug client fix: debug client etherscan Dec 24, 2024
@mattsse
Copy link
Collaborator

mattsse commented Dec 24, 2024

Fixes the tag for the debug client, as the Display implementation for BlockNumberOrTag

meh this is a bit weird

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nit

crates/consensus/debug-client/src/providers/etherscan.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the C-bug An unexpected or incorrect behavior label Dec 24, 2024
@greged93
Copy link
Contributor Author

actually I think the block number needs to be in hex @mattsse

Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #13542 will not alter performance

Comparing greged93:fix/debug-client (9bc8fff) with main (cec31ad)

Summary

✅ 77 untouched benchmarks

@mattsse
Copy link
Collaborator

mattsse commented Dec 24, 2024

I see, then let's format this as hex then

@mattsse mattsse enabled auto-merge December 25, 2024 08:22
@mattsse mattsse added this pull request to the merge queue Dec 25, 2024
Merged via the queue into paradigmxyz:main with commit 3fbb230 Dec 25, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants