chore: make NodeEvent generic over NodePrimitives
#13534
Merged
+32
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
onbjerg,
gakonst and
fgimenez
as code owners
mattsse
approved these changes
Dec 23, 2024
| @@ -350,12 +353,12 @@ struct CurrentStage { | |||
| } | |||
|
|
|||
| /// A node event. | |||
| #[derive(Debug)] | |||
| pub enum NodeEvent { | |||
| #[derive(Debug, derive_more::From)] | |||
mattsse
added
A-observability
klkvr
force-pushed
the
klkvr/generic-node-event
branch
from
1c4f128 to
82837e6
Compare
klkvr
force-pushed
the
klkvr/generic-node-event
branch
from
82837e6 to
c11f8a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #13533
We need to propagate
NodePrimitivestoBeaconConsensusEngineEvent