Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the command example in the comments Update main.rs #13524

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

famouswizard
Copy link
Contributor

I noticed a typo in the comment section of the code. Specifically, in the command example:

//! cargo run -p beacon-api-beacon-sidecar-fetcher --node -- full

There is an extra space between --node and full, which could cause confusion or errors when running the command. The correct version should be:

//! cargo run -p beacon-api-beacon-sidecar-fetcher --node --full

I’ve fixed this typo to ensure the command is properly formatted and avoids any potential issues when users follow the example.

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #13524 will not alter performance

Comparing famouswizard:patch-2 (dcaa2d4) with main (855029b)

Summary

✅ 69 untouched benchmarks
🆕 8 new benchmarks
⁉️ 8 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main famouswizard:patch-2 Change
⁉️ `prefix set preload size: 100 input size: 100 BTreeSet with BTreeSet:range lookup`
⁉️ `prefix set preload size: 100 input size: 100 BTreeSet with Iterator:any lookup`
⁉️ `prefix set preload size: 100 input size: 100 Vec with binary search lookup`
⁉️ `prefix set preload size: 100 input size: 100 Vec with custom cursor lookup`
🆕 `prefix set preload size: 100 input size: 99 BTreeSet with BTreeSet:range lookup`
🆕 `prefix set preload size: 100 input size: 99 BTreeSet with Iterator:any lookup`
🆕 `prefix set preload size: 100 input size: 99 Vec with binary search lookup`
🆕 `prefix set preload size: 100 input size: 99 Vec with custom cursor lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 BTreeSet with BTreeSet:range lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 BTreeSet with Iterator:any lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
🆕 `prefix set preload size: 1000 input size: 999 BTreeSet with BTreeSet:range lookup`
🆕 `prefix set preload size: 1000 input size: 999 BTreeSet with Iterator:any lookup`
🆕 `prefix set preload size: 1000 input size: 999 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 999 Vec with custom cursor lookup`

@mattsse mattsse merged commit 50dfd30 into paradigmxyz:main Dec 23, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants