Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make ReceiptFileClient generic over receipt #13523

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 23, 2024

Adds helper ReceiptDecoder which allows to use its Receipt AT directly on ReceiptFileClient and to get rid of phantomdata.

Additionally makes HackReceiptFileCodec generic over receipt being decoded and provides impl for OpReceipt

@mattsse mattsse added the A-sdk Related to reth's use as a library label Dec 23, 2024
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #13523 will not alter performance

Comparing klkvr/generic-receipt-file-client (dd4715f) with main (ec21e89)

Summary

✅ 73 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main klkvr/generic-receipt-file-client Change
⁉️ `prefix set preload size: 1000 input size: 997 BTreeSet with BTreeSet:range lookup`
⁉️ `prefix set preload size: 1000 input size: 997 BTreeSet with Iterator:any lookup`
⁉️ `prefix set preload size: 1000 input size: 997 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 997 Vec with custom cursor lookup`
🆕 `prefix set preload size: 1000 input size: 998 BTreeSet with BTreeSet:range lookup`
🆕 `prefix set preload size: 1000 input size: 998 BTreeSet with Iterator:any lookup`
🆕 `prefix set preload size: 1000 input size: 998 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 998 Vec with custom cursor lookup`

@klkvr klkvr added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 855029b Dec 23, 2024
43 of 44 checks passed
@klkvr klkvr deleted the klkvr/generic-receipt-file-client branch December 23, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants