Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(engine): use ParallelProof::multiproof in StateRootTask #13260

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Dec 10, 2024

Requires #13416

Proof::overlay_multiproof -> ParallelProof::multiproof

@fgimenez fgimenez force-pushed the fgimenez/srt-parallel-multiproof branch 2 times, most recently from 2dcc160 to b44ff11 Compare December 13, 2024 09:27
@fgimenez fgimenez added C-perf A change motivated by improving speed, memory usage or disk footprint A-blockchain-tree Related to sidechains, reorgs and pending blocks A-trie Related to Merkle Patricia Trie implementation labels Dec 13, 2024
@fgimenez fgimenez marked this pull request as ready for review December 13, 2024 14:39
@fgimenez fgimenez requested review from shekhirin, Rjected, mattsse and rkrasiuk and removed request for Rjected, gakonst, mattsse and rkrasiuk December 13, 2024 14:40
@fgimenez fgimenez force-pushed the fgimenez/srt-parallel-multiproof branch from 9bf7a4d to 22cf1b8 Compare December 17, 2024 09:59
@fgimenez fgimenez changed the base branch from main to fgimenez/chunked-parallel-multiproof December 17, 2024 09:59
crates/engine/tree/src/tree/root.rs Outdated Show resolved Hide resolved
@fgimenez fgimenez force-pushed the fgimenez/chunked-parallel-multiproof branch from 1fdf1ca to d2372a3 Compare December 17, 2024 15:27
@fgimenez fgimenez force-pushed the fgimenez/srt-parallel-multiproof branch from 962be85 to 89333b9 Compare December 17, 2024 15:29
@fgimenez fgimenez force-pushed the fgimenez/chunked-parallel-multiproof branch from 05c1a3d to 4514574 Compare December 17, 2024 16:01
@fgimenez fgimenez force-pushed the fgimenez/srt-parallel-multiproof branch from 89333b9 to ef38e76 Compare December 17, 2024 16:05
@fgimenez fgimenez force-pushed the fgimenez/chunked-parallel-multiproof branch from 4514574 to 37fb95f Compare December 18, 2024 06:22
@fgimenez fgimenez force-pushed the fgimenez/srt-parallel-multiproof branch from ef38e76 to dd5d1f4 Compare December 18, 2024 07:44
@fgimenez fgimenez force-pushed the fgimenez/srt-parallel-multiproof branch 2 times, most recently from 2691434 to 6fb7b31 Compare December 18, 2024 08:11
@fgimenez fgimenez force-pushed the fgimenez/chunked-parallel-multiproof branch from 37fb95f to 52f9ae3 Compare December 18, 2024 20:52
@fgimenez fgimenez force-pushed the fgimenez/srt-parallel-multiproof branch from 6fb7b31 to 8b32977 Compare December 18, 2024 21:08
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

crates/engine/tree/src/tree/root.rs Show resolved Hide resolved
Base automatically changed from fgimenez/chunked-parallel-multiproof to main December 19, 2024 12:02
@fgimenez fgimenez force-pushed the fgimenez/srt-parallel-multiproof branch from deef662 to e534cb8 Compare December 19, 2024 12:10
@fgimenez fgimenez enabled auto-merge December 19, 2024 12:11
@fgimenez fgimenez added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 0a0a2d4 Dec 19, 2024
42 checks passed
@fgimenez fgimenez deleted the fgimenez/srt-parallel-multiproof branch December 19, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants