Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for merging yet
I would like to start a series of opinionated code cleanup:
Now that we use
babel
es6 features can be used without restrictions.Changes
Change I made for now, only in
controller.mjs
class
def for the controller.if
sequences byswitch
es. This is very opinionated, I can rewind if needed.jshint
and reformat withjavascript prettier
. We might want to add these tools to the build chain.Questions
Most of the key shortcuts do nothing, is that expected ? (zoom, rotate etc)
What is the difference between "t" and "T" ?