Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor workflow and pass diff files correctly #1004

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Refactor workflow and pass diff files correctly #1004

merged 1 commit into from
Dec 17, 2024

Conversation

ForestEckhardt
Copy link
Contributor

  • Removed test that only check the status of output variables in favor of using those variables outright this should reduce our overhead by reducing the number of VMs we need to acquire
  • Collapse evaluating jobs into a higher level job to both reduce overhead as well as reduce file passing in the case of package diffing

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@ForestEckhardt ForestEckhardt requested a review from a team as a code owner December 17, 2024 18:16
@ForestEckhardt
Refactor workflow and pass diff files correctly
a8b323d 
- Removed test that only check the status of output variables in favor
  of using those variables outright this should reduce our overhead by
  reducing the number of VMs we need to acquire
- Collapse evaluating jobs into a higher level job to both reduce
  overhead as well as reduce file passing in the case of package diffing
@ForestEckhardt ForestEckhardt merged commit 825e683 into main Dec 17, 2024
4 checks passed
@ForestEckhardt ForestEckhardt deleted the simplify-stack-release branch December 17, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdimsdale robdimsdale robdimsdale approved these changes

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer is a code owner automatically assigned from paketo-buildpacks/tooling-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ForestEckhardt @robdimsdale