hotfix: properly handle purl encoding #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove unneed exception raising for the version param * do not skip URL encoding `:` and `+` characters * add test cases from old issues refs: #45, #46, #57 Signed-off-by: Steven Esser <[email protected]>
steven-esser
requested review from
sschuberth,
pombredanne and
stevespringett
matt-phylum
reviewed
Nov 9, 2023
test/data/test-suite-data.json
Outdated
| @@ -122,7 +122,7 @@ | |||
| { | |||
| "description": "docker uses qualifiers and hash image id as versions", | |||
| "purl": "pkg:docker/customer/dockerimage@sha256:244fd47e07d1004f0aed9c?repository_url=gcr.io", | |||
| "canonical_purl": "pkg:docker/customer/dockerimage@sha256:244fd47e07d1004f0aed9c?repository_url=gcr.io", | |||
| "canonical_purl": "pkg:docker/customer/dockerimage@sha256%3A244fd47e07d1004f0aed9c?repository_url=gcr.io", | |||
There was a problem hiding this comment.
The official test input says this should be unencoded (':').
I recommend keeping test-suite-data.json exactly the same as in the spec repository and making a separate file for tests that are unique to this repository. That makes it easier to ensure this implementation matches the spec, easier to update the copy of the test suite file, and easier to find tests that could be added to the spec.
|
Any updates when this will be merged? |
steven-esser
force-pushed
the
57-fix-version-bug
branch
from
7ba01c1 to
2a4018a
Compare
Signed-off-by: Steven Esser <[email protected]>
steven-esser
force-pushed
the
57-fix-version-bug
branch
from
2a4018a to
f3ee1ba
Compare
|
Is there an ETA on getting this in? |
|
Closing as covered by #71 |
|
v2.0.0 has been published 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:and+charactersrefs: #45, #46, #57