-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sighting GPS location widget #91
Open
achou11
wants to merge
11
commits into
main
Choose a base branch
from
33/sighting-gps-location
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreae
reviewed
May 30, 2024
still missing actual map
achou11
force-pushed
the
33/sighting-gps-location
branch
from
June 28, 2024 18:47
f53e8f8
to
15e9802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33
Notes:
Introduces a new dependency: Flutter MapLibre GL
we're currently using the default map style that comes from the MapLibreGL project. It's very barebones and we probably should not stick with it in the long term due to (presumable) maintenance burden for them and also lack of detail in general. we should decide on a map provider or look into implementing offline maps (which is more work)
as a follow-up, in the case that we're using online map styles+tiles, it would make sense to create a setting that defines the style URL for the maps to use. the reason for doing this instead of hardcoding the url somewhere in the app code is to mitigate usability issues in the case of a service outage or a mishap with the access token. We made this mistake at my work recently (we rotated an API key by accident) and the only way to unbreak maps on peoples' devices was to do another release of the app. with the settings-based approach, users can at least insert another URL (whether it be for another map provider or the same one but with a working API key) and not have to wait on the devs to fix the app code and make an app release.
Preview
End-to-end flow:
had to split it up due to video size limits
Part 1:
location_field_1.mp4
Part 2:
location_field_2.mp4
Screenshots:
Read mode when:
location is set:
location is not set:
Edit mode when:
location is set:
(before pressing map)
(after pressing map)
location is not set: