Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sighting GPS location widget #91

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

achou11
Copy link
Collaborator

@achou11 achou11 commented May 17, 2024

Closes #33

Notes:

  • Introduces a new dependency: Flutter MapLibre GL

  • we're currently using the default map style that comes from the MapLibreGL project. It's very barebones and we probably should not stick with it in the long term due to (presumable) maintenance burden for them and also lack of detail in general. we should decide on a map provider or look into implementing offline maps (which is more work)

  • as a follow-up, in the case that we're using online map styles+tiles, it would make sense to create a setting that defines the style URL for the maps to use. the reason for doing this instead of hardcoding the url somewhere in the app code is to mitigate usability issues in the case of a service outage or a mishap with the access token. We made this mistake at my work recently (we rotated an API key by accident) and the only way to unbreak maps on peoples' devices was to do another release of the app. with the settings-based approach, users can at least insert another URL (whether it be for another map provider or the same one but with a working API key) and not have to wait on the devs to fix the app code and make an app release.


Preview

End-to-end flow:

had to split it up due to video size limits

Part 1:

location_field_1.mp4

Part 2:

location_field_2.mp4

Screenshots:

  • Read mode when:

    • location is set:

      image
    • location is not set:

      image
  • Edit mode when:

    • location is set:

      (before pressing map)

      image

      (after pressing map)

      image
    • location is not set:

      image

@adzialocha adzialocha changed the title 33/sighting gps location Sighting GPS location widget May 21, 2024
@adzialocha adzialocha mentioned this pull request May 21, 2024
9 tasks
@achou11 achou11 force-pushed the 33/sighting-gps-location branch from f53e8f8 to 15e9802 Compare June 28, 2024 18:47
@achou11 achou11 marked this pull request as ready for review June 28, 2024 19:09
@achou11 achou11 requested review from adzialocha and sandreae June 28, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking: Sighting Screen
2 participants