Add feedback-guided scheduling algorithms #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add feedback guided scheduling algorithms. * Fix tests. * Add location information to events. * fix change.
* Disable trace logging to save disk space. * Update feedback algorithm. * fix feedback strategy. * refactor. * Remove experiment features. --------- Co-authored-by: Ao Li <[email protected]>
* Added support for generating a warning when spec handles an event but does not add it in its observes list (#716) * Create custom converter for JSON serialization in .NET8 (#717) * Create custom converter for JSON serialization in .NET8 * Add check for different dictionary type for null replacement --------- Co-authored-by: Eric Hua <[email protected]> --------- Co-authored-by: Ankush Desai <[email protected]> Co-authored-by: Eric Hua <[email protected]> Co-authored-by: Eric Hua <[email protected]>
* Added support for generating a warning when spec handles an event but does not add it in its observes list (#716) * Create custom converter for JSON serialization in .NET8 (#717) * Create custom converter for JSON serialization in .NET8 * Add check for different dictionary type for null replacement --------- Co-authored-by: Eric Hua <[email protected]> * udpate. * update. * update. --------- Co-authored-by: Eric Hua <[email protected]> Co-authored-by: Eric Hua <[email protected]> Co-authored-by: Ao Li <[email protected]>
Co-authored-by: Christine Zhou <[email protected]>
Remove conflict analysis
Co-authored-by: Christine Zhou <[email protected]>
ankushdesai
reviewed
Oct 10, 2024
Src/PChecker/CheckerCore/SystematicTesting/ControlledRuntime.cs
Outdated
Show resolved
Hide resolved
...er/CheckerCore/SystematicTesting/Strategies/Feedback/Generator/Mutator/RandomInputMutator.cs
Outdated
Show resolved
Hide resolved
|
|
||
| internal class RandomScheduleMutator : IMutator<RandomScheduleGenerator> | ||
| { | ||
| private readonly int _meanMutationCount = 10; |
There was a problem hiding this comment.
why these values 10 and not something else?
ankushdesai
requested changes
Oct 11, 2024
Src/PChecker/CheckerCore/SystematicTesting/ControlledRuntime.cs
Outdated
Show resolved
Hide resolved
|
Based on the discussion today, can @aoli-al you please do the following refactoring:
|
ankushdesai
requested changes
Oct 18, 2024
| where T: IConvertible | ||
| { | ||
| internal readonly System.Random Random; | ||
| public int Pos; |
There was a problem hiding this comment.
There seems to be bug here, pos is never initialized to 0?
There was a problem hiding this comment.
This is not necessary. Pos is default to 0 during initialization.
There was a problem hiding this comment.
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public uint Seed { get; set; } |
There was a problem hiding this comment.
When is this Seed being set?
There was a problem hiding this comment.
Seed is not used in ControlledRandom. This field is added to implement the IRandomValueGenerator interface
|
|
||
| public ControlledRandom Mutate() | ||
| { | ||
| return new ControlledRandom(Utils.MutateRandomChoices(IntChoices, 5, 5, IntChoices.Random), |
There was a problem hiding this comment.
Why do we only mutate only 5 times?
There was a problem hiding this comment.
This is a hyper-parameter. 5 is the mean mutation count and mean mutation size here. Not a fixed number.
ankushdesai
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following scheduling algorithm: