Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing compiler changes #789

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Removing compiler changes #789

merged 1 commit into from
Oct 9, 2024

Conversation

ChristineZh0u
Copy link
Contributor

Creating separate PRs for each cleanup task. This PR removes the changes in PCompiler

@aoli-al
Copy link
Contributor

aoli-al commented Oct 9, 2024

Can you double-check the changes we made in the CompilerCore? master...experimental/feedback

You reverted more changes than needed.

@ChristineZh0u
Copy link
Contributor Author

Can you double-check the changes we made in the CompilerCore? master...experimental/feedback

You reverted more changes than needed.

The reason PEvent.cs, Event.cs, and PMachine.cs are changed is because there's a variable in CSharpCodeGenerator.cs called _sendEventIndex which is uses as a parameter called int Loc when initializing an Event. Is that variable needed? Or did I removed too much from somewhere else?

@aoli-al
Copy link
Contributor

aoli-al commented Oct 9, 2024

For example, I don't think I have changed .github/workflows/pcover.yml, which is included in your change list. I'm working on a rebuttal these days and will take a closer look this Friday.

A good way to verify is to check if you have changed more files listed here master...experimental/feedback

@ChristineZh0u
Copy link
Contributor Author

For example, I don't think I have changed .github/workflows/pcover.yml, which is included in your change list. I'm working on a rebuttal these days and will take a closer look this Friday.

A good way to verify is to check if you have changed more files listed here master...experimental/feedback

Ohh i see, all the .github folder changes are to eliminate the github warnings. I'll revert them back. And yes, I've made sure that all changes are in the master...experimental/feedback. Good luck with rebuttal!

@ChristineZh0u ChristineZh0u force-pushed the experimental/feedback_cleanup branch from 3df1840 to c22c64d Compare October 9, 2024 02:25
ankushdesai
ankushdesai approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@ankushdesai ankushdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aoli-al
Copy link
Contributor

aoli-al commented Oct 9, 2024

Thanks! LGTM!

@ankushdesai ankushdesai merged commit ccaa276 into experimental/feedback Oct 9, 2024
14 checks passed
@ankushdesai ankushdesai deleted the experimental/feedback_cleanup branch October 9, 2024 16:09
ankushdesai added a commit that referenced this pull request Oct 18, 2024
@aoli-al @ankushdesai @ChristineZh0u
Add feedback-guided scheduling algorithms (#791)
b45194b 
* Add feedback strategy. (#715)

* Add feedback guided scheduling algorithms.

* Fix tests.

* Add location information to events.

* fix change.

* Improving the code with some cleanup. (#719)

* Disable trace logging to save disk space.

* Update feedback algorithm.

* fix feedback strategy.

* refactor.

* Remove experiment features.

---------

Co-authored-by: Ao Li <[email protected]>

* PR cleanup (#723)

* Added support for generating a warning when spec handles an event but does not add it in its observes list (#716)

* Create custom converter for JSON serialization in .NET8 (#717)

* Create custom converter for JSON serialization in .NET8

* Add check for different dictionary type for null replacement

---------

Co-authored-by: Eric Hua <[email protected]>

---------

Co-authored-by: Ankush Desai <[email protected]>
Co-authored-by: Eric Hua <[email protected]>
Co-authored-by: Eric Hua <[email protected]>

* Merge Recent Bug Fixes (#778)

* Added support for generating a warning when spec handles an event but does not add it in its observes list (#716)

* Create custom converter for JSON serialization in .NET8 (#717)

* Create custom converter for JSON serialization in .NET8

* Add check for different dictionary type for null replacement

---------

Co-authored-by: Eric Hua <[email protected]>

* udpate.

* update.

* update.

---------

Co-authored-by: Eric Hua <[email protected]>
Co-authored-by: Eric Hua <[email protected]>
Co-authored-by: Ao Li <[email protected]>

* Fix feedback strategy and remove experiment features.

* Removing Pattern (#786)

Co-authored-by: Christine Zhou <[email protected]>

* Remove conflict analysis

* Removing compiler changes (#789)

Co-authored-by: Christine Zhou <[email protected]>

* Cleanup.

* Revert changes to Event.

* Revert changes.

* Fix merge conflicts.

* Remove temp file.

* Rename LastSentReceiver to MessageReceiver

* Simplify scheduler implementation.

* Revert changes in QLearning strategy.

* Refactor.

* Added VectorTime and BehavioralObserver class for feedback strategy (#799)

Co-authored-by: Christine Zhou <[email protected]>

* Revert changes in PCTStrategy.

* Revert changes in Probabilistic folder.

* revert change.

---------

Co-authored-by: Ankush Desai <[email protected]>
Co-authored-by: ChristineZh0u <[email protected]>
Co-authored-by: Christine Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankushdesai ankushdesai ankushdesai approved these changes

@aoli-al aoli-al aoli-al approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineZh0u @aoli-al @ankushdesai