Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dockerfile #54

Closed
wants to merge 1 commit into from
Closed

added dockerfile #54

wants to merge 1 commit into from

Conversation

leisefuxX
Copy link

added and testet dockerfile

added and testet dockerfile
@leisefuxX
Copy link
Author

didn't touch any code at all.
just commented favicon, css and html out in gosh.yml

FROM golang:alpine AS build_base

## add git
RUN apk add --no-cache git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am uncertain why Git is needed in the Dockerfile. Could you explain your motive?

@riotbib
Copy link
Contributor

riotbib commented Feb 18, 2024

Hej @leisefuxX thanks for your PR!

I guess @oxzi will want the Dockerfile to be moved under contrib/docker/ e.g, as it's already done with the OpenBSD and NixOS deployment.

@leisefuxX leisefuxX closed this Feb 18, 2024
@oxzi
Copy link
Owner

oxzi commented Feb 22, 2024

Thanks @riotbib for your first review!

For the record, this PR was re-opened as #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants