-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Camelyon16 benchmark #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to update the results running fed_benchmark on the new Camelyon16 and updates corresponding results (leaving a copy of the old one for legacy purposes) in this PR as well as its plot putting old and new results side by side.
a5dbc05
to
505e044
Compare
505e044
to
9da48d3
Compare
4912af0
to
0541b4d
Compare
5f29aed
to
07ecf9d
Compare
07ecf9d
to
68016dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work !
Can you:
- rename all old files with the suffix "_old" including (
results_benchmark_fed_camelyon.csv
toresults_benchmark_fed_camelyon_old.csv
so the file should not be changed directly only copied) - new results are called like the old ones were before aka wo any suffix (no _vf)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ! Can you:
- rename all old files with the suffix "_old" including (
results_benchmark_fed_camelyon.csv
toresults_benchmark_fed_camelyon_old.csv
so the file should not be changed directly only copied)- new results are called like the old ones were before aka wo any suffix (no _vf)
It seems I hallucinated on this one ! LGTM !
Fix the number of sampled tiles to 10 000 and ensure reproducibility by fixing torch RNG state
Results obtained with the
fed_benchmark.py
script:New one
Old one