🐛 (scatter/marimekko) apply color/size tolerance early #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 5 (8a28a6) ❌ Edited: 2024-12-18 10:18:17 UTC |
sophiamersmann
force-pushed
the
fix-scatter-color
branch
from
fd03b51 to
dcdaf21
Compare
sophiamersmann
force-pushed
the
fix-scatter-color
branch
from
dcdaf21 to
0a3f0f4
Compare
marcelgerber
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4284 by applying color tolerance before the author's timeline filter is applied to the input table.
This is how the bug for gray scatter plots like this one happened:
timelineMaxis set to 2021[timelineMin, timelineMax], thereby dropping years 2022 and 2023 including all color valuestransformTablefunction, Grapher applies infinite tolerance to the color dimension, but since all colour values have been removed, the colour column remains emptyFixed by running colour (and size) tolerance for scatter and marimekkos earlier.