🔨 (line legend) refactor label dropping algorithm #4310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
7cce411 to
0f14805
Compare
sophiamersmann
force-pushed
the
line-legend-refactor-viz
branch
from
8b5c0ec to
eb7b1e1
Compare
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
0f14805 to
23f6d25
Compare
sophiamersmann
force-pushed
the
line-legend-refactor-viz
branch
2 times, most recently
from
4f1a64a to
a5caed0
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 2 (f9fd29) ❌ Edited: 2024-12-19 10:41:05 UTC |
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
23f6d25 to
1efc37f
Compare
sophiamersmann
force-pushed
the
line-legend-refactor-viz
branch
from
a5caed0 to
770d172
Compare
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
1efc37f to
ff455a2
Compare
sophiamersmann
force-pushed
the
line-legend-refactor-viz
branch
from
770d172 to
1599e40
Compare
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
ff455a2 to
46aec6b
Compare
sophiamersmann
force-pushed
the
line-legend-refactor-viz
branch
from
1599e40 to
7f96dff
Compare
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
2 times, most recently
from
91ab2bd to
7b66a4d
Compare
sophiamersmann
force-pushed
the
line-legend-refactor-viz
branch
from
7f96dff to
b1fb797
Compare
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
7b66a4d to
c415e0b
Compare
sophiamersmann
force-pushed
the
line-legend-refactor-viz
branch
2 times, most recently
from
06d9453 to
3bbb970
Compare
marcelgerber
approved these changes
Dec 18, 2024
packages/@ourworldindata/grapher/src/lineLegend/LineLegendFilterAlgorithms.ts
Outdated
Show resolved
Hide resolved
packages/@ourworldindata/grapher/src/lineLegend/LineLegendHelpers.ts
Outdated
Show resolved
Hide resolved
packages/@ourworldindata/grapher/src/lineLegend/LineLegendHelpers.ts
Outdated
Show resolved
Hide resolved
packages/@ourworldindata/grapher/src/lineLegend/LineLegendHelpers.ts
Outdated
Show resolved
Hide resolved
packages/@ourworldindata/grapher/src/lineLegend/LineLegendHelpers.ts
Outdated
Show resolved
Hide resolved
packages/@ourworldindata/grapher/src/lineLegend/LineLegendHelpers.ts
Outdated
Show resolved
Hide resolved
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
c415e0b to
df36918
Compare
sophiamersmann
force-pushed
the
line-legend-refactor-viz
branch
from
0161ee8 to
8896fae
Compare
sophiamersmann
changed the base branch from
line-legend-tests-viz
to
graphite-base/4310
sophiamersmann
force-pushed
the
line-legend-refactor-viz
branch
from
8896fae to
4d76221
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the code that is responsible for dropping labels if there is not enough space.
The SVG tester comes back with one additional difference. It's a slope charts where the 'Tanzania' and 'Mali' labels are swapped. Tanzania should be on top (its value is 1339) and 'Mali' should be below (its value is 1337), so the updated chart is correct.