Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: explorer tile touchups #4220

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Nov 26, 2024

When I was looking at our homepage in Safari 13.1, I noticed that the explorer tiles were basically nonfunctional:
CleanShot 2024-11-26 at 16 18 33

This is because the background image for these is only provided as a webp, and 13.1 doesn't support webp yet. Obviously one solution would be to provide that image in a different format also, but I thought the simpler solution here would be to just provide a background color, so the white text can be read.

I think this still looks decent, and is relatively rare either way:
CleanShot 2024-11-26 at 16 20 59

I've also taken on the freedom to add a classname that was missing before, such that we now get a background for the icon - which Marwa has recently complained about. The CSS definitions for this were there already.

Also, for completeness, here's a screenshot of it in its full working glory:
CleanShot 2024-11-26 at 16 22 13

@marcelgerber marcelgerber marked this pull request as ready for review November 26, 2024 15:22
@marcelgerber marcelgerber requested a review from ikesau November 26, 2024 15:23
Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is justified as a straight-up accessibility enhancement, too 🙌

@owidbot
Copy link
Contributor

owidbot commented Nov 26, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-explorer-tiles-touchups

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-26 15:35:27 UTC
Execution time: 1.24 seconds

@marcelgerber marcelgerber merged commit 5edb37a into master Nov 26, 2024
25 of 27 checks passed
@marcelgerber marcelgerber deleted the explorer-tiles-touchups branch November 26, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants