🎉 Cloudflare images

[ikesau]

Adds support for Cloudflare Images
Drops support for Gdrive Images

Project checklist

Can be QA'd on staging, or locally with the following steps:

1. Check this branch out
2. yarn runDbMigrations
3. yarn syncCloudflareImages
4. Set the following env variables:

CLOUDFLARE_IMAGES_ACCOUNT_ID=available in cloudflare, on the main "images" page
CLOUDFLARE_IMAGES_API_KEY=generate your own with read and write permissions
CLOUDFLARE_IMAGES_URL=available in cloudflare, on the main "images" page. looks like "https://imagedelivery.net/owid-account-id/"

Images can now be created, updated, and deleted in the admin, under /admin/images

All environments share the same "prod" cloudflare images space, so it's okay to delete the images that are currently uploaded now, but eventually we'll have to be careful not to delete images in prod from our local & staging environments 😬

TODO

• A follow-up PR that removes googleId from the images table and type definitions once this PR has proven to be stable

[owidbot]

Quick links (staging server):

Site Dev	Site Preview	Admin	Wizard	Docs

Login: ssh owid@staging-site-cloudflare-images

• Site-screenshots: https://github.com/owid/site-screenshots/compare/cloudflare-images
• SVG tester: https://github.com/owid/owid-grapher-svgs/compare/cloudflare-images

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-29 21:55:45 UTC
Execution time: 1.28 seconds

[rakyi]

Great work! I'm happy we are finally doing this.

• Too bad we didn't talk about this sooner, but I think it would make sense to use the official TS library for Cloudflare API instead of making the raw fetch requests for some more (type) safety and a nicer DX.
• Will the existing old image URLs keep working at least for a few months, ideally indefinitely? I'm thinking about the atom feeds and newsletters, at least the DI newsletter references the image URL directly. And who knows how many links in the wild point to one of our images. I think it would be worth to spend a few hours on this if necessary.
• This wasn't too bad, but I'd appreciate it if a feature like this was split into multiple smaller PRs in the future, which would be easier to review.

[rakyi]

This is an unusual usage of useMemo. Is there a reason why we do this? It doesn't seem like we really need it, and if we do, useCallback would be IMO nicer.

[danyx23]

Hey there! Just a drive by comment as I got an email about Martin's review. I'd be in favour of polishing this quite a bit - I think it would be nice if we don't have to touch images for a long time after this :)

[larsyencken]

A really nice improvement! 🎉

Aside from small issues I slacked you about, the main piece of feedback is around possible benefits of checksums in the images table.