Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix unpublished chart delete #4211

Merged
merged 1 commit into from
Dec 5, 2024
+8 −6
Merged

🐛 fix unpublished chart delete #4211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions adminSiteServer/apiRouter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,12 +1066,14 @@ deleteRouteWithRWTransaction(
"/charts/:chartId",
async (req, res, trx) => {
const chart = await expectChartById(trx, req.params.chartId)
const links = await getPublishedLinksTo(trx, [chart.slug!])
if (links.length) {
const sources = links.map((link) => link.sourceSlug).join(", ")
throw new Error(
`Cannot delete chart in-use in the following published documents: ${sources}`
)
if (chart.slug) {
const links = await getPublishedLinksTo(trx, [chart.slug])
if (links.length) {
const sources = links.map((link) => link.sourceSlug).join(", ")
throw new Error(
`Cannot delete chart in-use in the following published documents: ${sources}`
)
}
}

await db.knexRaw(trx, `DELETE FROM chart_dimensions WHERE chartId=?`, [
Expand Down
Loading