feat(admin): Admin for narrative views

[marcelgerber]

This PR introduces most of the basic admin functionality needed for narrative views, but not quite all of it just yet. But I think this is ready for a review for at this point, anyhow.

Part of #4128.

Features:

• Rename chart_views#slug column to #name
• A new page listing all narrative views, under /admin/chartViews (based on antd table)
• Create a new chart view based on a parent chart
• Have chart views included in Refs tab
• Show diff between parent chart and view

Open questions:

• For indicators, the children charts are listed in the "Inheritance" tab. For charts, I have now opted to unify all uses of a chart in the "Refs" tab. Does this make sense, or do we want to unify that?

Screenshots

[marcelgerber]

• refactor(admin): move admin inheritance tab to refs tab #4253
• refactor(grapher): better handling of query params #4248
• feat(admin): Admin for narrative views #4208 👈 (View in Graphite)
• feat: API handlers for narrative views #4201
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[owidbot]

Quick links (staging server):

Site Dev	Site Preview	Admin	Wizard	Docs

Login: ssh owid@staging-site-narrative-views-admin

• Site-screenshots: https://github.com/owid/site-screenshots/compare/narrative-views-admin
• SVG tester: https://github.com/owid/owid-grapher-svgs/compare/narrative-views-admin

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-22 17:22:01 UTC
Execution time: 1.24 seconds

Copilot reviewed 5 out of 13 changed files in this pull request and generated no suggestions.

Files not reviewed (8)

• adminSiteClient/ChartEditor.ts: Evaluated as low risk
• adminSiteClient/ChartViewEditor.ts: Evaluated as low risk
• packages/@ourworldindata/types/src/dbTypes/ChartViews.ts: Evaluated as low risk
• adminShared/AdminTypes.ts: Evaluated as low risk
• db/migration/1733004083678-RenameChartViewsSlug.ts: Evaluated as low risk
• adminSiteClient/AdminSidebar.tsx: Evaluated as low risk
• adminSiteClient/AdminApp.tsx: Evaluated as low risk
• adminSiteClient/EditorReferencesTab.tsx: Evaluated as low risk

Comments skipped due to low confidence (2)

adminSiteClient/SaveButtons.tsx:224

• [nitpick] The button text 'Go to parent chart' could be more descriptive. Consider renaming it to 'Edit parent chart' for clarity.

Go to parent chart

adminSiteClient/SaveButtons.tsx:127

• [nitpick] The button text 'Save as narrative view' could be more descriptive. Consider renaming it to 'Create narrative view' for consistency with other button texts.

Save as narrative view

[danyx23]

Very nice work, Marcel! I left a few minor comments but this is coming along nicely :). A way to delete narrative views that are not referenced would be good to add.

[danyx23]

Just a thought: we could allow changing the name as long as there are no active references. We don't have to do this now but if typos happen then this might be nice.

[danyx23]

I get a squiggly line here that this needs a label. It's debug functionality but maybe worth it for a cleaner editor experience :)

[marcelgerber]

Must be some kind of editor (accessibility?) plugin that you have and I don't?
Anyhow, I tried quickly adding one and then the layout broke, and I couldn't be arsed 😀

[danyx23]

This will work on prod but not on staging servers, right? Could we make this work now that we have CF preview deploys?

[marcelgerber]

No, this will also work on staging sites, as long as that config is available.

See http://staging-site-marcel/grapher/by-uuid/0191b6c7-364e-7cf2-be6e-8cee8e073203.svg, for example!