Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ center prominent link content when no description is present #4197

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Nov 20, 2024

Per Marwa's request

image

Test data:

{.prominent-link}
url: https://ourworldindata.org/child-mortality
title: Child Mortality
thumbnail: child-mortality-thumbnail.png
{}

{.prominent-link}
url: https://ourworldindata.org/child-mortality
title: Child Mortality
thumbnail: child-mortality-thumbnail.png
description: Child mortality is one of the world’s largest problems. Around 6 million children under 15 die per year. That’s around 16,000 deaths every day, or 11 every minute.
{}

@ikesau ikesau requested a review from rakyi November 20, 2024 19:32
@owidbot
Copy link
Contributor

owidbot commented Nov 20, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-prominent-link-touchup

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-20 19:51:40 UTC
Execution time: 1.16 seconds

Copy link
Contributor

@rakyi rakyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ikesau ikesau merged commit 055b5c3 into master Nov 25, 2024
26 of 27 checks passed
@ikesau ikesau deleted the prominent-link-touchup branch November 25, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants