🎉 enable line/slope chart switching in explorers

owid · Dec 11, 2024 · 5180a0e · 5180a0e
1 parent 9f3a070
commit 5180a0e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/adminSiteClient/EditorBasicTab.tsx b/adminSiteClient/EditorBasicTab.tsx
@@ -368,10 +368,6 @@ export class EditorBasicTab<
                 ? []
                 : [value as GrapherChartType]
 
-        if (grapher.isLineChart) {
-            this.addSlopeChart()
-        }
-
         if (grapher.isMarimekko) {
             grapher.hideRelativeToggle = false
             grapher.stackMode = StackMode.relative

diff --git a/packages/@ourworldindata/explorer/src/ExplorerProgram.ts b/packages/@ourworldindata/explorer/src/ExplorerProgram.ts
@@ -66,7 +66,7 @@ interface ExplorerGrapherInterface extends GrapherInterface {
     relatedQuestionText?: string
     relatedQuestionUrl?: string
     mapTargetTime?: number
-    type?: GrapherChartType | "None"
+    type?: GrapherChartType | "LineChart SlopeChart" | "None"
 }
 
 const ExplorerRootDef: CellDef = {

diff --git a/packages/@ourworldindata/explorer/src/GrapherGrammar.ts b/packages/@ourworldindata/explorer/src/GrapherGrammar.ts
@@ -3,6 +3,7 @@ import {
     ColorSchemeName,
     FacetAxisDomain,
     FacetStrategy,
+    GRAPHER_CHART_TYPES,
     GRAPHER_TAB_OPTIONS,
     MissingDataStrategy,
     StackMode,
@@ -66,10 +67,11 @@ export const GrapherGrammar: Grammar<GrapherCellDef> = {
         description: `The type of chart to show such as LineChart or ScatterPlot. If set to None, then the chart tab is hidden.`,
         terminalOptions: toTerminalOptions([
             ...ALL_GRAPHER_CHART_TYPES,
+            `${GRAPHER_CHART_TYPES.LineChart} ${GRAPHER_CHART_TYPES.SlopeChart}`,
             "None",
         ]),
         toGrapherObject: (value) => ({
-            chartTypes: value === "None" ? [] : [value],
+            chartTypes: value === "None" ? [] : value.split(" "),
         }),
     },
     grapherId: {