Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3/reqbodyproc #2045

Open
wants to merge 3 commits into
base: v3/master
Choose a base branch
from
Open

Conversation

airween
Copy link
Member

@airween airween commented Mar 11, 2019

In the v2 reference, the REQUEST_BODY variable info contains:

Holds the raw request body. This variable is available only if the URLENCODED request body processor was used, which will occur by default when the application/x-www-form-urlencoded content type is detected, or if the use of the URLENCODED request body parser was forced.

Now the REQUEST_BODY in libmodsec3 always evaluated, no matter what is the content-type. Eg. the CT is application/xml, and the SecRule operator is @rx, then it checked with the regex pattern.

CRS regression tests showed that in case of XML, JSON and Multipart CT's don't allows the REQUEST_BODY variable. See the attached regression test json file.

Note, that this modification needs to disable the REQUEST_BODY check in the offset_variable.json, when the CT is Multipart.

@victorhora victorhora added enhancement 3.x Related to ModSecurity version 3.x pr available workaround available The issue has either a temporary or permanent workaround available labels Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Related to ModSecurity version 3.x enhancement pr available workaround available The issue has either a temporary or permanent workaround available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants