Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle jvm source and target compatibility in each module #126

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

overpas
Copy link
Owner

@overpas overpas commented Oct 27, 2024

Closes #125


PR-Codex overview

This PR focuses on enhancing Kotlin compilation settings across various Gradle build files by specifying jvmTarget and Java compatibility based on project properties, while also removing commented-out code related to a benchmark configuration.

Detailed summary

  • Added JvmTarget import and configuration for KotlinCompile tasks in benchmark/build.gradle.kts.
  • Introduced Java source and target compatibility settings in sample/desktop/build.gradle.kts.
  • Implemented KotlinCompile task configuration in sample/android/build.gradle.kts.
  • Removed commented-out benchmark configuration in sample/android/build.gradle.kts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@overpas overpas merged commit 70b31ce into master Oct 27, 2024
2 checks passed
@overpas overpas deleted the #125/jvm-version branch October 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix jvm source and target compatibility issues
1 participant