Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DNS error handling #350

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Improve DNS error handling #350

merged 4 commits into from
Dec 6, 2024

Conversation

dylanratcliffe
Copy link
Member

No description provided.

@dylanratcliffe dylanratcliffe changed the title Added DNS to health check Improve DNS error handling Dec 6, 2024
@DavidS-ovm
Copy link
Contributor

ah, ha. Found the rate limiting specs:

There is a 1024 packet per second (PPS) limit to services that use link-local addresses. This limit includes the aggregate of Route 53 Resolver DNS queries, Instance Metadata Service (IMDS) requests, Amazon Time Service Network Time Protocol (NTP) requests, and Windows Licensing Service (for Microsoft Windows based instances) requests. This quota cannot be increased.

(via https://docs.aws.amazon.com/vpc/latest/userguide/AmazonDNS-concepts.html#vpc-dns-limits)

@dylanratcliffe
Copy link
Member Author

That's definitely really high for our purposes right?

DavidS-ovm
DavidS-ovm reviewed Dec 6, 2024
View reviewed changes
adapters/dns.go Outdated Show resolved Hide resolved
adapters/dns.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
adapters/dns.go Outdated Show resolved Hide resolved
adapters/dns.go Show resolved Hide resolved
@DavidS-ovm
Copy link
Contributor

That's definitely really high for our purposes right?

Yeah, we're far away from that limit, but it is also an order of magnitude less than I thought it was. And hitting it will impact everything in our VPC, so it's something to keep in mind for the future.

@dylanratcliffe dylanratcliffe merged commit 9a288de into main Dec 6, 2024
5 checks passed
@dylanratcliffe dylanratcliffe deleted the dns-improvements branch December 6, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS-ovm DavidS-ovm DavidS-ovm approved these changes

@tphoney tphoney Awaiting requested review from tphoney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanratcliffe @DavidS-ovm