100% test coverage #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osteel
commented
May 29, 2023
Comment on lines
-14
to
-17
| public function all(TaxYearId $taxYearId): Generator | ||
| { | ||
| return $this->retrieveAll($taxYearId); | ||
| } |
osteel
commented
May 29, 2023
| @@ -42,7 +42,7 @@ protected static function newFactory(): SharePoolingAssetAcquisitionFactory | |||
| return SharePoolingAssetAcquisitionFactory::new(); | |||
| } | |||
|
|
|||
| public function averageCostBasisPerUnit(): ?FiatAmount | |||
| public function averageCostBasisPerUnit(): FiatAmount | |||
There was a problem hiding this comment.
ℹ️ Can't actually be null (wondering why PHPStan didn't pick this up)
osteel
commented
May 29, 2023
Comment on lines
+27
to
32
| /** | ||
| * @return Traversable<int, SharePoolingAssetTransaction> | ||
| * | ||
| * @codeCoverageIgnore | ||
| */ | ||
| public function getIterator(): Traversable |
There was a problem hiding this comment.
ℹ️ Needs to be implemented because of the IteratorAggregate interface, but I don't actually use it anywhere
osteel
force-pushed
the
debt/test-coverage
branch
from
bb75560 to
e17e53f
Compare
osteel
force-pushed
the
debt/test-coverage
branch
from
e17e53f to
324d0e1
Compare
osteel
commented
May 29, 2023
osteel
commented
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings test coverage to 100% of the code base.
Explanation
I previously removed the test coverage constraint because 1) I was in a rush and 2) the report seemed to ignore the
domainfolder.I've since then identified that the reason for the latter was I was using PCOV, which doesn't read
phpunit.xmlproperly. Switching to Xdebug for coverage fixes the issue.Checklist