Include an arm64 shared library in the ruby gem #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
jdeff
changed the title
…asks Rationale: 2.6.10 is what ships with macOS 14.0 even though support for it stopped in March of 2022 and 3.2 is the latest stable version.
jdeff
force-pushed
the
arm64-support-in-ruby
branch
from
39ca190 to
c1a839a
Compare
Disable new cops for existing violations
Add the host and bindings parameters so calls that contain them don't fail typecheck
…Github actions The rationale for this is from the way that docs diffing works. Both the base branch and the new branch need to be able to build using the version of Ruby supported by that branch. Without this change, when a PR is introduced that updates the target Ruby version, a followup PR will be required to update the github action for building the 'base' branch's version of the docs. With this change, github actions will choose the version of Ruby targeted by the branch it is trying to build
|
Any thoughts on this PR? Maybe @gj? |
|
Another friendly ping on this change. Any questions or concerns @gj? I understand the project is going to be deprecated, but we would still find this change useful. |
|
Hey @jdeff, thanks for the follow-up, and I'm sorry for not responding sooner. I don't have any concerns; just need to test it out. |
|
Hi @jdeff, this keeps getting bumped as other stuff comes up, but I will get to it. Hopefully this week. |
Seeing if [this](cross-rs/cross#724 (comment)) is a quick fix so I can avoid any deeper debugging.
This reverts commit 7feebd1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a Ruby on Rails application using Docker for Mac on my Apple Silicon machine, I am unable run
osobecause the shared library for linux included in the gem,libpolar.so, only supports x86_64 and my container is arm64. This change compiles both an x86_64 shared lib as well as a new aarch64 shared lib and adds them both to the gem.PR checklist: