fling fix #20933
Open
fling fix #20933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshcherb
reviewed
Nov 5, 2024
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <androidx.core.widget.NestedScrollView | |||
There was a problem hiding this comment.
Here was no problem as I remember
vshcherb
reviewed
Nov 5, 2024
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <androidx.core.widget.NestedScrollView | |||
| <ScrollView | |||
There was a problem hiding this comment.
We can't use ScrollView / NestedScrollView coudln't be used here cause it's already inside scrollview. Also we need to use recyclerview for tag/ values on advanced tabs
Chumva
reviewed
Dec 23, 2024
Chumva
reviewed
Dec 23, 2024
| basicTagsInitialized = true; | ||
| } | ||
|
|
||
| public class OpeningHoursAdapter { |
There was a problem hiding this comment.
Copy pasted class from the previous screen?
Chumva
reviewed
Dec 23, 2024
| import gnu.trove.list.array.TIntArrayList; | ||
| import studio.carbonylgroup.textfieldboxes.ExtendedEditText; | ||
|
|
||
| public class EditPoiContentAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder> { |
There was a problem hiding this comment.
Quite bug class, better to move inner classes to separate files
Chumva
reviewed
Dec 23, 2024
| import java.util.Locale; | ||
| import java.util.Map; | ||
|
|
||
| public class NewBasicEditPoiFragment extends BaseOsmAndFragment implements EditPoiDialogFragment.OnFragmentActivatedListener { |
There was a problem hiding this comment.
It looks like there is issue with scroll height
 |
|---|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.