-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix KPI_EXTRACTION deadlock and missing EXPERIMENT_NAME strings to unblock CDP processing #185
base: master
Are you sure you want to change the base?
Conversation
…NAME changes. Signed-off-by: MichaelTiemannOSC <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: MichaelTiemannOSC <[email protected]>
@MichaelTiemannOSC: The following test failed, say
Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I've tried, and again failed, to squash these changes properly. Here's the garbage cluttering my terminal window in my JupyterHub notebook:
I'm trying so hard to learn the Git/GitHub system enough that I can make basic changes like these without breaking everything, but I just haven't been around the block enough times to make it natural to me. I really don't understand what its telling me about not concluding/finishing a merge, because the diffs of these two commits are the complete changes I wanted to push. |
I have hand-picked changes from cdp2-experiments that have unblocked the processing of CDP reports. The two principal changes are:
Signed-off-by: MichaelTiemannOSC [email protected]