Add configure method in lexicographic_ordering #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the configure method for the struct Config, which define the gates and constraints for proving the correctness of the sorted memory trace array.
This PR fixes the errors in lexicographic_ordering.rs
This PR adds the second constraint in the configure function, i.e, requiring all the pairwise limb differences before the first_different_limb is zero.
This PR adds the helper functions in gadget.rs for supporting the constraints in lexicographic ordering
This PR fixes the constraints in the configure method of struct LexicographicChip
This PR continues implementing the gates for the lexcographic chip
… of the permutation argument
This PR add helper functions for assigning the witnesses for the synthesize method in struct LexicographicCircuit.
This PR restructure the LexicographicCircuit struct and add a ProvableTraceRecord which allow all elements to have Field type.
…nd successive powers as functions
This PR add the gate for constraining the first time address it accessed, the instruction must be equal to 1, and also add testcases for debugging.
| } | ||
|
|
||
| struct SortedTraceRecord<F: Field + PrimeField> { | ||
| address: [F; 32], //64 bits |
There was a problem hiding this comment.
Seems like the comments are wrong
HappyFalcon22
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the configure method for the struct Config, which define the gates and constraints for proving the correctness of the sorted memory trace array.