Feature/support memory consistency with Nova #166
Annotations
6 errors and 6 warnings
used `assert_ne!` with a literal bool:
zkmemory/src/nova/testcases.rs#L427
error: used `assert_ne!` with a literal bool
--> zkmemory/src/nova/testcases.rs:427:9
|
427 | assert_ne!(res.is_ok(), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
help: replace it with `assert!(..)`
|
427 - assert_ne!(res.is_ok(), true);
427 + assert!(!res.is_ok());
|
|
used `assert_ne!` with a literal bool:
zkmemory/src/nova/testcases.rs#L364
error: used `assert_ne!` with a literal bool
--> zkmemory/src/nova/testcases.rs:364:9
|
364 | assert_ne!(res.is_ok(), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
help: replace it with `assert!(..)`
|
364 - assert_ne!(res.is_ok(), true);
364 + assert!(!res.is_ok());
|
|
used `assert_ne!` with a literal bool:
zkmemory/src/nova/testcases.rs#L301
error: used `assert_ne!` with a literal bool
--> zkmemory/src/nova/testcases.rs:301:9
|
301 | assert_ne!(res.is_ok(), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
help: replace it with `assert!(..)`
|
301 - assert_ne!(res.is_ok(), true);
301 + assert!(!res.is_ok());
|
|
used `assert_ne!` with a literal bool:
zkmemory/src/nova/testcases.rs#L238
error: used `assert_ne!` with a literal bool
--> zkmemory/src/nova/testcases.rs:238:9
|
238 | assert_ne!(res.is_ok(), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
= note: `#[deny(clippy::bool_assert_comparison)]` implied by `#[deny(warnings)]`
help: replace it with `assert!(..)`
|
238 - assert_ne!(res.is_ok(), true);
238 + assert!(!res.is_ok());
|
|
use of a fallible conversion when an infallible one could be used:
zkmemory/src/commitment/kzg.rs#L370
error: use of a fallible conversion when an infallible one could be used
--> zkmemory/src/commitment/kzg.rs:370:37
|
370 | let chunk_fr: [u8; 32] = fr.try_into().expect("Cannot convert from Fr to bytes");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: converting `Fr` to `[u8; 32]` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
note: the lint level is defined here
--> zkmemory/src/lib.rs:6:5
|
6 | warnings,
| ^^^^^^^^
= note: `#[deny(clippy::unnecessary_fallible_conversions)]` implied by `#[deny(warnings)]`
help: use
|
370 - let chunk_fr: [u8; 32] = fr.try_into().expect("Cannot convert from Fr to bytes");
370 + let chunk_fr: [u8; 32] = fr.into();
|
|
Clippy
Clippy had exited with the 101 exit code
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|