Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stepsize as a parameter that can be passed to the model #66

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

harivnkochi
Copy link
Contributor

Sometimes choosing a smaller step size helps propagation, because Bellhop's default stepsize (activated if you pass 0 to env file) is channeldepth/10. Currently the uwapm model does not accept stepsize as a parameter though it can be passed to bellhop.

@mchitre
Copy link
Member

mchitre commented May 25, 2021

Uh, why is bubble resonance changes in this PR?

@mchitre
Copy link
Member

mchitre commented Feb 23, 2024

@harivnkochi still planning to follow up on this someday?

@harivnkochi
Copy link
Contributor Author

Yes :-) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants