Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9946] chore: add coccoapods support to bundle privacy manifest file #542

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Jan 12, 2024

Summary

  • Without the resource_bundles specification in podspec, cocoapods doesn't include the PrivacyInfo.xcprivacy file into the main app bundle. It causes third party SDK's privacy to be missing in the main app's privacy report.
  • Ref pod#10325

Test plan

  • Follow the steps:
    1. Add dependency into a demo app.
    2. Archive the app
    3. Generate privacy report and verify report

Issues

@muzahidul-opti muzahidul-opti marked this pull request as ready for review January 12, 2024 17:02
@muzahidul-opti muzahidul-opti requested a review from a team as a code owner January 12, 2024 17:02
@muzahidul-opti muzahidul-opti requested a review from jaeopt January 12, 2024 17:02
Copy link
Collaborator

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 6377fe6 into master Jan 15, 2024
11 of 13 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/pod-support-privacy-manifest branch January 15, 2024 11:14
@muzahidul-opti muzahidul-opti changed the title [FSSDK-9946] chore: add coccoapods support for privacy manifest [FSSDK-9946] chore: add coccoapods support to bundle privacy manifest file Jan 19, 2024
muzahidul-opti added a commit that referenced this pull request Jan 19, 2024
* Privacy access api types value updated (#541)

* Add coccoapods support for privacy manifest (#542)

* [FSSDK-9950] chore: SPM support added to process privacy manifest (#544)

* SPM support added for privacy manifes file

* Compiled language version added

* Update CHANGELOG.md

* Update README.md

* Update swift.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants