Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9899] fix: hub, command not found #536

Merged
merged 2 commits into from
Jan 4, 2024
Merged

[FSSDK-9899] fix: hub, command not found #536

merged 2 commits into from
Jan 4, 2024

Conversation

muzahidul-opti
Copy link
Contributor

Summary

Test plan

  • prepare_for_release and release workflow should pass.

Issues

@muzahidul-opti muzahidul-opti requested a review from a team as a code owner January 3, 2024 15:55
@muzahidul-opti muzahidul-opti requested a review from jaeopt January 3, 2024 16:14
jaeopt
jaeopt requested changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A suggestion.

.github/workflows/swift.yml Outdated Show resolved Hide resolved
jaeopt
jaeopt approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 04eabbf into master Jan 4, 2024
18 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/check-release-script branch January 4, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@muzahidul-opti muzahidul-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @jaeopt